-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Implement PAIR #255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urn new conversation and fully remove edge cases with UUID collisions.
romanlutz
reviewed
Jun 24, 2024
romanlutz
reviewed
Jun 24, 2024
romanlutz
reviewed
Jun 24, 2024
romanlutz
reviewed
Jun 27, 2024
…ation starts when `start_new_conversation` is set to true. Previously, it always evaluated to True.
rlundeen2
reviewed
Jun 27, 2024
rlundeen2
reviewed
Jun 27, 2024
rlundeen2
reviewed
Jun 27, 2024
refactor: improve readability of `author` field. Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
romanlutz
reviewed
Jul 24, 2024
romanlutz
reviewed
Jul 26, 2024
…ing_chat, fix tests
romanlutz
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
MemoryInterface.duplicate_conversation_for_new_orchestrator()
to return theconversation_id
of the new conversation and removes edge cases related to UUID collisions. This caused some tests to be removed and another one updated.tests/test_attack_strategy.py
.Tests and Documentation
MemoryInterface.duplicate_conversation_for_new_orchestrator()
and one updated.