Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update chat client & multiturn notebooks with more information #25

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Update chat client & multiturn notebooks with more information #25

merged 4 commits into from
Feb 2, 2024

Conversation

romanlutz
Copy link
Contributor

@romanlutz romanlutz commented Jan 26, 2024 •
edited
Loading

Description

This PR aims to improve the information presented in the notebooks.

  1. Add more information to chat client notebook. We've gotten a few questions about how chat clients are different from red teaming bot, and whether we can provide an example for red teaming with just the chat client.
  2. Make multiturn strategies notebook more presentable since it needed some polishing. Probably self-explanatory, but let me know if you have thoughts!

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited
Loading

Test Results

72 tests  ±0   72 ✅ ±0   6s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit e8d457a. ± Comparison against base commit b67f726.

♻️ This comment has been updated with latest results.

rlundeen2
rlundeen2 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@rlundeen2 rlundeen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once Nina's comments are addressed!

@romanlutz romanlutz merged commit f7352a9 into main Feb 2, 2024
7 checks passed
@romanlutz romanlutz deleted the romanlutz/notebook_updates branch February 2, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdheekonda rdheekonda rdheekonda left review comments

@nina-msft nina-msft nina-msft left review comments

@rlundeen2 rlundeen2 rlundeen2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romanlutz @rdheekonda @rlundeen2 @nina-msft