-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Add CodeChameleon converter #240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start @jl8771 ! Ping me when you have a version with tests and I'll make another pass.
…s/codechameleon
Are you planning to add tests for the others as well or only custom? |
@romanlutz I had tests for the other modes as well but removed them as the standard encryption methods (reverse, binary tree, odd even, and length) are protected and should only be called internally. If you think it would be better to add them back, I can add them. |
Can you elaborate on protected? I can call them via the constructor arg, so the underscore at the start of the method doesn't mean that users won't use the functionality. Or am I missing something? |
I had not considered that, only that the user would not directly call them. I'll add the tests for those encryption functions. |
Description
Add converter based on CodeChameleon paper. Adds ability for user to specify custom
encrypt and decrypt functions in addition to existing encrypt/decrypt functions from paper.
Tests and Documentation
Test added for converter using custom encrypt and decrypt functions.