Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove poetry #24

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Remove poetry #24

merged 3 commits into from
Jan 29, 2024

Conversation

romanlutz
Copy link
Contributor

Description

This PR is a proposal to remove poetry in favor of just using conda from now on. Note that corresponding changes to the wiki will have to be made after merging (if we do choose to go with this).

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

Copy link

github-actions bot commented Jan 26, 2024

Test Results

72 tests  ±0   72 ✅ ±0   8s ⏱️ -5s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit b3d72cd. ± Comparison against base commit 5a6fdf7.

♻️ This comment has been updated with latest results.

@romanlutz romanlutz marked this pull request as ready for review January 26, 2024 19:34
Copy link
Contributor

@nina-msft nina-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you either link a PR to what wiki changes would need to be made after this merges, or include those changes in this PR? That would make it easier to test this as a reviewer as well :)

@romanlutz
Copy link
Contributor Author

Can you either link a PR to what wiki changes would need to be made after this merges, or include those changes in this PR? That would make it easier to test this as a reviewer as well :)

The wiki isn't part of the repo, so I can't share a PR or add the changes. In essence, it would come down to this:

git clone <repo url>
cd <repo folder>
conda create -n <env name> python=<python version>
conda activate <env name>
pip install -e .
... # start contributing!

I can also link to the conda website for installation. Anything else you think is missing?

@rlundeen2
Copy link
Contributor

Also just a reminder since this is a decent change; please wait 24 hours for other folks to give feedback (even tho I think all have chimed in)

@romanlutz
Copy link
Contributor Author

Also just a reminder since this is a decent change; please wait 24 hours for other folks to give feedback (even tho I think all have chimed in)

100%. This applies to all PRs (except perhaps changes of the magnitude of a typo fix, etc.).

@Azure Azure deleted a comment from nina-msft Jan 27, 2024
@Azure Azure deleted a comment from rdheekonda Jan 27, 2024
@romanlutz romanlutz force-pushed the romanlutz/remove_poetry branch 2 times, most recently from 56c6f73 to 7f76556 Compare January 27, 2024 00:27
@romanlutz romanlutz merged commit 9ce03a5 into main Jan 29, 2024
7 checks passed
@romanlutz romanlutz deleted the romanlutz/remove_poetry branch January 29, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants