New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT Making Prompt Converters Async #211

Merged

jbolor21 merged 12 commits into Azure:main from jbolor21:users/bjagdagdorj/asyncConvert

May 20, 2024

Contributor

jbolor21 commented May 16, 2024

Description

Making all prompt converters async and fixing unit tests accordingly

Tests and Documentation

Ran and created new unit tests to test async functionality

jbolor21 added 2 commits

May 16, 2024 13:25


          initial commit adding changed converters

84b9347


          added unit tests and fixed rest of converters

4d5fa13

jbolor21 marked this pull request as ready for review

May 16, 2024 21:50

jbolor21 added 3 commits

May 16, 2024 14:58


          fixing unit test

783e6a9


          precommit fixes

bed1ebd


          precommit

456cf74

rlundeen2 reviewed

View reviewed changes

pyrit/prompt_converter/azure_speech_text_to_audio_converter.py Outdated Show resolved Hide resolved

rlundeen2 reviewed

View reviewed changes

pyrit/prompt_converter/add_text_image_converter.py Outdated Show resolved Hide resolved

rlundeen2 reviewed

View reviewed changes

pyrit/prompt_converter/prompt_converter.py Outdated Show resolved Hide resolved

rlundeen2 reviewed

View reviewed changes

pyrit/prompt_converter/ascii_art_converter.py Outdated Show resolved Hide resolved

rlundeen2 reviewed

View reviewed changes

pyrit/prompt_converter/translation_converter.py Outdated Show resolved Hide resolved

jbolor21 added 2 commits

May 16, 2024 19:27


          Merge branch 'main' of https://github.com/Azure/PyRIT into users/bjag…

bc94d51

…dagdorj/asyncConvert

merging


          replaced convert with async convert

e74c3c8

rlundeen2 reviewed

View reviewed changes

pyrit/orchestrator/red_teaming_orchestrator.py Outdated Show resolved Hide resolved

rlundeen2 reviewed

View reviewed changes

pyrit/prompt_normalizer/prompt_normalizer.py Outdated Show resolved Hide resolved


          small change, get rid of tenacity in converter

c6942ec

rlundeen2 reviewed

View reviewed changes

pyrit/prompt_normalizer/prompt_normalizer.py Outdated Show resolved Hide resolved

Contributor

rlundeen2 commented May 17, 2024

Can you please run all notebooks before merging to make sure nothing is broken? Make sure to not commit the new notebooks where nothing has changed, but we want to make sure there aren't errors :)

.\doc\generate_docs\run_jupytext.ps1 -runId xxx

rlundeen2 approved these changes

View reviewed changes

Contributor

rlundeen2 left a comment

Looking great! Please ping if you're unsure about any comments or you want more direction/feedback :)

jbolor21 added 4 commits

May 17, 2024 20:02


          addressing feedback renaming functions to _async

2dfcc82


          renaming async functions and fix notebooks

d5e6abf


          renaming async functions

b59db7c


          Merge branch 'main' of https://github.com/Azure/PyRIT into users/bjag…

2d0668e

…dagdorj/asyncConvert

jbolor21 merged commit 5a85020 into Azure:main

5 checks passed

jbolor21 deleted the users/bjagdagdorj/asyncConvert branch

May 20, 2024 20:16

SafwanA02 added a commit to SafwanA02/PyRIT that referenced this pull request


          Revert "MAINT Making Prompt Converters Async (Azure#211)"

157cabe

This reverts commit 5a85020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment