-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Centralize Exception Handling and Implement in GPTv Target #207
Merged
rdheekonda
merged 12 commits into
Azure:main
from
rdheekonda:users/rdheekonda/add-exception-handling
May 20, 2024
Merged
FEAT: Centralize Exception Handling and Implement in GPTv Target #207
rdheekonda
merged 12 commits into
Azure:main
from
rdheekonda:users/rdheekonda/add-exception-handling
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlundeen2
reviewed
May 16, 2024
pyrit/prompt_target/prompt_chat_target/azure_openai_gptv_chat_target.py
Outdated
Show resolved
Hide resolved
rlundeen2
reviewed
May 16, 2024
pyrit/prompt_target/prompt_chat_target/azure_openai_gptv_chat_target.py
Outdated
Show resolved
Hide resolved
rlundeen2
reviewed
May 16, 2024
pyrit/prompt_target/prompt_chat_target/azure_openai_gptv_chat_target.py
Outdated
Show resolved
Hide resolved
rlundeen2
reviewed
May 16, 2024
pyrit/prompt_target/prompt_chat_target/azure_openai_gptv_chat_target.py
Outdated
Show resolved
Hide resolved
rlundeen2
reviewed
May 16, 2024
pyrit/prompt_target/prompt_chat_target/azure_openai_gptv_chat_target.py
Outdated
Show resolved
Hide resolved
As part of this, can you take a stab at documenting what we should do? E.g. this is my best stab at a strategy, which is similar to but different from the one you have coded
|
rdheekonda
changed the title
[DRAFT] Add exception handling
FEAT: Centralize Exception Handling and Implement in GPTv Target
May 17, 2024
rlundeen2
reviewed
May 17, 2024
rlundeen2
reviewed
May 17, 2024
rlundeen2
reviewed
May 17, 2024
rlundeen2
reviewed
May 17, 2024
rlundeen2
reviewed
May 17, 2024
pyrit/prompt_target/prompt_chat_target/azure_openai_gptv_chat_target.py
Outdated
Show resolved
Hide resolved
rlundeen2
reviewed
May 17, 2024
rlundeen2
reviewed
May 17, 2024
rlundeen2
reviewed
May 17, 2024
rlundeen2
reviewed
May 17, 2024
rlundeen2
reviewed
May 17, 2024
rlundeen2
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests and Documentation
Added tests