MAINT: Deprecated send_prompt methods #204

mart123p · 2024-05-15T16:40:18Z

Description

Finished the deprecation send_prompts methods in Prompt Targets. There is now a single code path for each Prompt Target.

Updated unit tests to use async version. There's still some work to do on the orchestrator to use async methods. This PR does not address this part.

pyrit/prompt_target/prompt_chat_target/azure_ml_chat_target.py

pyrit/prompt_target/prompt_chat_target/ollama_chat_target.py

rlundeen2

Let me know if you have questions on the comments; but everything is looking great!

…23p/PyRIT into users/mpouliot/prompt_target_async

Martin Pouliot added 10 commits May 15, 2024 01:14

Deprecated send_prompt methods

50e1292

Reverted to old prompt chat target

dbcd72c

Removed tests since they can't be mocked

190def9

Undid changes on openai chat target

cb27e6d

Replaced unit tests to use async instead

a4340cd

Updated notebooks to use async

7102f40

Fixed linting issues

a4eeb2a

Removed complete_chat, will need to adjust unit tests

1b292cc

Fixed unit tests

494d786

Reformatted files

9b3be99

mart123p changed the title ~~[DRAFT] MAINT: Deprecated send_prompt methods~~ MAINT: Deprecated send_prompt methods May 15, 2024

rlundeen2 reviewed May 16, 2024

View reviewed changes

pyrit/prompt_target/prompt_chat_target/azure_ml_chat_target.py Show resolved Hide resolved

rlundeen2 reviewed May 16, 2024

View reviewed changes

pyrit/prompt_target/prompt_chat_target/ollama_chat_target.py Show resolved Hide resolved

rlundeen2 approved these changes May 16, 2024

View reviewed changes

mart123p and others added 2 commits May 16, 2024 17:15

Merge branch 'main' into users/mpouliot/prompt_target_async

f303e63

Merge branch 'users/mpouliot/prompt_target_async' of github.com:mart1…

3e0fec6

…23p/PyRIT into users/mpouliot/prompt_target_async

rlundeen2 merged commit 02ed3e5 into Azure:main May 17, 2024
5 checks passed