Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Making RESULTS_PATH be sane in pip packages #191

Merged
merged 3 commits into from
May 8, 2024
Merged

FIX: Making RESULTS_PATH be sane in pip packages #191

merged 3 commits into from
May 8, 2024

Conversation

rlundeen2
Copy link
Contributor

@rlundeen2 rlundeen2 commented May 7, 2024 •
edited
Loading

Description

Making default RESULTS_PATH be sane in pip packages

Tests and Documentation

  • Tested that it works in a repo
  • Tested if you manually set it to be outside of a repo, the DATASETS path works as expected in windows

rdheekonda
rdheekonda reviewed May 7, 2024
View reviewed changes
pyrit/common/path.py Outdated Show resolved Hide resolved
@rlundeen2 rlundeen2 merged commit 9b40842 into Azure:main May 8, 2024
5 checks passed
QDAP-Fred pushed a commit to QDAP-Fred/QUART that referenced this pull request May 13, 2024
@rlundeen2 @QDAP-Fred
FIX: Making RESULTS_PATH be sane in pip packages (Azure#191)
6cec93c 
* FIX: Making RESULTS_PATH be sane in pip packages

* prebuild

* pr feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdheekonda rdheekonda rdheekonda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rlundeen2 @rdheekonda