-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Refactoring and Standardizing Scores and Scorers #190
Merged
rlundeen2
merged 26 commits into
Azure:main
from
rlundeen2:users/rlundeen/4_25_scoring_db_update
May 8, 2024
Merged
FEAT: Refactoring and Standardizing Scores and Scorers #190
rlundeen2
merged 26 commits into
Azure:main
from
rlundeen2:users/rlundeen/4_25_scoring_db_update
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
reviewed
May 7, 2024
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
…b.com/rlundeen2/pyrit into users/rlundeen/4_25_scoring_db_update
rdheekonda
reviewed
May 8, 2024
rdheekonda
reviewed
May 8, 2024
rdheekonda
reviewed
May 8, 2024
rdheekonda
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
romanlutz
approved these changes
May 8, 2024
QDAP-Fred
pushed a commit
to QDAP-Fred/QUART
that referenced
this pull request
May 13, 2024
* adding classifier code * saving changes * test working * saving changes * saving changes * score design mostly done * fixing up notebooks and small bugs * fixing up tests * tests passing * Prebuild * docs * docs * fixing build * fixing tests * Update pyrit/score/scorer.py Co-authored-by: Roman Lutz <romanlutz13@gmail.com> * Update pyrit/score/scorer.py Co-authored-by: Roman Lutz <romanlutz13@gmail.com> * Update pyrit/score/self_ask_true_false_scorer.py Co-authored-by: Roman Lutz <romanlutz13@gmail.com> * Update pyrit/score/self_ask_category_scorer.py Co-authored-by: Roman Lutz <romanlutz13@gmail.com> * Update pyrit/score/self_ask_category_scorer.py Co-authored-by: Roman Lutz <romanlutz13@gmail.com> * Update pyrit/score/self_ask_likert_scorer.py Co-authored-by: Roman Lutz <romanlutz13@gmail.com> * pr feedback * fixing bug --------- Co-authored-by: Roman Lutz <romanlutz13@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Standardizing scorers and scores
Tests and Documentation
Jupytext run; score documents updated, scorer tests written