Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT Add Request Validation for All Prompt Targets #184

Merged
merged 8 commits into from
May 1, 2024
Merged

MAINT Add Request Validation for All Prompt Targets #184

merged 8 commits into from
May 1, 2024

Conversation

rdheekonda
Copy link
Contributor

Description

  • Added prompt request validation across all prompt targets.
  • Added validate_request abstract method to PromptTarget class
  • Ensured consistency in Azure completions chat target unit tests, aligning with other targets to obtain mock data.
  • Added tests for gandalf target

Tests and Documentation

Added new unit tests and ran jupytext

nina-msft
nina-msft requested changes May 1, 2024
View reviewed changes
Copy link
Contributor

@nina-msft nina-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

completed my first pass through -- there are some comments that i'd like to see fixed before merge! otherwise validation is a good idea, thanks raja :)

@rdheekonda rdheekonda merged commit f6450cf into Azure:main May 1, 2024
5 checks passed
QDAP-Fred pushed a commit to QDAP-Fred/QUART that referenced this pull request May 13, 2024
@rdheekonda @QDAP-Fred
MAINT Add Request Validation for All Prompt Targets (Azure#184)
502faad 
* MAINT Add request validatiom for all prompt targets

* Fix mypy errors

* Mypy error

* Fix bad merge

* Address PR feedback

* Removed sync validation tests in test prompt target text

* Address PR feedback

---------

Co-authored-by: Raja Sekhar Rao Dheekonda <rdheekonda@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlundeen2 rlundeen2 rlundeen2 left review comments

@romanlutz romanlutz romanlutz approved these changes

@nina-msft nina-msft nina-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rdheekonda @romanlutz @rlundeen2 @nina-msft