FEAT Add User AuthN Support to AOAI Chat Targets #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nina-msft
commented
Apr 30, 2024
nina-msft
changed the title
rlundeen2
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
This looks great! Before merging please
- Test in an actual endpoint. We don't necessarily need this permanently added to jupyter notebooks although that's not a bad idea.
- Unit tests to check the paths are set correctly
Feel free to hit me up if you want me to take another look :)
rdheekonda
approved these changes
Apr 30, 2024
nina-msft
changed the title
@rlundeen I tested with AOAIChatTarget using the endpoint that I have user auth permissions with and verified it works :-) Updated the documentation to highlight this flag as an option, but set it to False by default so that API KEY is used from .env I added a unit test for the Azure Auth functionality, I'm not sure what you mean by checking paths. Let me know if there's other testing needed! |
rdheekonda
approved these changes
Apr 30, 2024
dlmgary
reviewed
Apr 30, 2024
dlmgary
reviewed
Apr 30, 2024
dlmgary
reviewed
Apr 30, 2024
dlmgary
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
use_aad_authparameter to all AOAIChatTarget implementations.FYI: @rdheekonda @rlundeen2
Tests and Documentation
use_aad_authflag toprompt_targets.pyand ran Jupytext on that notebook