Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT fix mypy issues, convert Azure completion class to target, fix AOAI and OAI tests, remove clip embedding class #172

Merged
merged 8 commits into from
Apr 25, 2024
Merged

MAINT fix mypy issues, convert Azure completion class to target, fix AOAI and OAI tests, remove clip embedding class #172

merged 8 commits into from
Apr 25, 2024

Conversation

romanlutz
Copy link
Contributor

Description

This change is motivated by the mypy failing in main right now. Addressing the issues took considerable refactoring that we had planned for anyway:

  • removing completions module
  • created target for Azure completions
  • created tests for Azure completions
  • rewrote tests for AOAI and OAI chat targets since it was very similar to the completions tests
  • fixed "Open AI" by removing extraneous whitespace where suitable.
  • deleted unused clip embedding class
  • fixed env var names in docstrings
  • made parsing method private by prefixing with underscore

Tests and Documentation

Updated tests. Still running notebooks.

rlundeen2
rlundeen2 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@rlundeen2 rlundeen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good PR!

rdheekonda
rdheekonda approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@rdheekonda rdheekonda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@romanlutz romanlutz merged commit 25fcafb into Azure:main Apr 25, 2024
5 checks passed
@romanlutz romanlutz deleted the romanlutz/mypy_Fix branch April 25, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdheekonda rdheekonda rdheekonda approved these changes

@rlundeen2 rlundeen2 rlundeen2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romanlutz @rdheekonda @rlundeen2