FEAT adding more authentication methods, add capital letters converter #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onverter included in this push
…onverter included in this push
romanlutz
changed the title
romanlutz
approved these changes
Apr 9, 2024
romanlutz
changed the title
rdheekonda
reviewed
Apr 10, 2024
rdheekonda
reviewed
Apr 10, 2024
romanlutz
reviewed
Apr 10, 2024
cseifert1
reviewed
Apr 11, 2024
rlundeen2
reviewed
Apr 11, 2024
There was a problem hiding this comment.
Generally, I would separate this into two PRs; one for authentication methods, one for capital letter converters. But not necessarily required going back and re-doing it (still that's probably what I'd do).
But the authentication piece needs some tests and some integration with targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will be more authentication methods to connect to AOAI services via interactive logins.
Tests and Documentation
Documentation provided in the authentication methods.