Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Fix internal document reference path #133

Merged
merged 2 commits into from
Apr 6, 2024
Merged

DOC: Fix internal document reference path #133

merged 2 commits into from
Apr 6, 2024

Conversation

libera826
Copy link
Contributor

Description

Fixed an issue with the internal document paths that the following notebooks were referencing.

  • doc/code/targets/chat/azure_openai_chat
  • doc/code/targets/azure_completions
  • doc/code/targets/prompt_targets

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

@libera826
Copy link
Contributor Author

@microsoft-github-policy-service agree company="SEOULIST LAB"

@libera826 libera826 marked this pull request as ready for review April 3, 2024 10:43
@romanlutz romanlutz added the documentation Improvements or additions to documentation label Apr 4, 2024
@romanlutz
Copy link
Contributor

@libera826 any reason for marking it as DRAFT? Looks ready to me.

@rlundeen2
Copy link
Contributor

rlundeen2 commented Apr 5, 2024 •
edited
Loading

Looks good to me; I'd approve if/when published :)

@libera826
Copy link
Contributor Author

As this is my first contribution to an open-source project, I have marked my submission as a DRAFT for precautionary measures.

Would it be advisable for me to remove the DRAFT label from the title of this pull request?

Thank you for your guidance.

@libera826 libera826 changed the title [DRAFT] DOC: Fix internal document reference path DOC: Fix internal document reference path Apr 5, 2024
@rlundeen2 rlundeen2 merged commit 3480f43 into Azure:main Apr 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanlutz romanlutz romanlutz approved these changes

@rlundeen2 rlundeen2 rlundeen2 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@libera826 @romanlutz @rlundeen2