-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: added a ChatMessageNormalizer that formats messages in the template specified by a Hugging Face tokenizer #128
Merged
blakebullwinkel
merged 10 commits into
Azure:main
from
blakebullwinkel:chat-message-normalizer-tokenizer
Mar 29, 2024
Merged
FEAT: added a ChatMessageNormalizer that formats messages in the template specified by a Hugging Face tokenizer #128
blakebullwinkel
merged 10 commits into
Azure:main
from
blakebullwinkel:chat-message-normalizer-tokenizer
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecified by a Hugging Face tokenizer
…ferent Hugging Face tokenizers
romanlutz
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! Do you see this being useful in any existing demo notebooks? No worries if not
…_message notebook
rlundeen2
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Blake! This is very poweful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a chat message normalizer called
ChatMessageNormalizerTokenizerTemplate
, which takes a Hugging Face tokenizer as input and allows you to convert a list of chat messages into the format specified by that tokenizer. This might be the ChatML format (which @dlmgary created a custom normalizerChatMessageNormalizerChatML
for) or some other custom format that was used to train the model.Tests and Documentation
I added tests to demonstrate that the normalizer works on three different Hugging Face tokenizers and some example usage to the
chat_message.ipynb
demo notebook.