Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT Add UTR39 confusability converter #115

Merged
merged 4 commits into from
Mar 20, 2024
Merged

FEAT Add UTR39 confusability converter #115

merged 4 commits into from
Mar 20, 2024

Conversation

yonatanzunger
Copy link
Contributor

Description

Add a new converter that uses UTR-39 Unicode confusability to try to work around filters.

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

rlundeen2
rlundeen2 reviewed Mar 20, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
rlundeen2
rlundeen2 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@rlundeen2 rlundeen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Approved with one suggestion :)

dlmgary
dlmgary approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@dlmgary dlmgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚢

@rlundeen2 rlundeen2 merged commit eacf7fc into Azure:main Mar 20, 2024
4 checks passed
@yonatanzunger yonatanzunger deleted the confusability branch March 20, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlmgary dlmgary dlmgary approved these changes

@rlundeen2 rlundeen2 rlundeen2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yonatanzunger @dlmgary @rlundeen2