Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding orchestrator abstract base class #102

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Adding orchestrator abstract base class #102

merged 5 commits into from
Mar 14, 2024

Conversation

rlundeen2
Copy link
Contributor

@rlundeen2 rlundeen2 commented Mar 14, 2024 •
edited
Loading

Description

  • Adds Orchestrator abstract base class. This class coalesces common orchestrator functionality. It's minimal right now, but soon will contain disposal members and will likely grow
  • Makes Gandalf Demo more robust
  • Fixes aml_endpoints doc to remove broken gandalf demo; we also want code execution time to be short here so probably don't want this for now.

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

romanlutz
romanlutz reviewed Mar 14, 2024
View reviewed changes
pyrit/orchestrator/orchestrator_class.py Show resolved Hide resolved
pyrit/orchestrator/orchestrator_class.py Outdated Show resolved Hide resolved
doc/demo/1_gandalf.ipynb Outdated Show resolved Hide resolved
@rlundeen2 rlundeen2 merged commit b3e5888 into Azure:main Mar 14, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdheekonda rdheekonda rdheekonda approved these changes

@romanlutz romanlutz romanlutz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rlundeen2 @romanlutz @rdheekonda