Add support for BRM schema changes #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BernieWhite any thoughts on this one? |
BernieWhite
requested changes
Jul 3, 2023
There was a problem hiding this comment.
Thanks for the contribution @jtracey93. Sorry this has taken a while to get to.
Mostly looks good, but double check my comments below. Otherwise all good to merge.
Also, I added some tests so we don't accidentally break this in the future. Double check you are ok this these.
Co-authored-by: Bernie White <bewhite@microsoft.com>
Co-authored-by: Bernie White <bewhite@microsoft.com>
|
@BernieWhite LGTM |
BernieWhite
approved these changes
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add support for BRM schema changes as per Azure/bicep#10810
Metadata usage changes for Bicep Module Registry
summarywill becomedescriptionto align with OCI registry (short summary/overview)description(old) will becomedetails(longer blurbs)PR Checklist