Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter type and require column to template doco #55

Closed
BernieWhite opened this issue Mar 10, 2021 · 0 comments · Fixed by #68
Closed

Add parameter type and require column to template doco #55

BernieWhite opened this issue Mar 10, 2021 · 0 comments · Fixed by #68
Assignees
@vicperdana
Labels
feature: documents Issues that affect Document definitions
Milestone
v0.3.0

Comments

@BernieWhite
Copy link
Contributor

Add type and required columns for parameter table.

We shouldn't require parameter metadata descriptions to include Required and Optional words since this can be automatically detected if a defaultValue is set.

Reference
@BernieWhite BernieWhite added the feature: documents Issues that affect Document definitions label Mar 10, 2021
@BernieWhite BernieWhite added this to the v0.3.0 milestone Mar 10, 2021
@vicperdana vicperdana mentioned this issue Mar 25, 2021
Merged
4 tasks
vicperdana added a commit that referenced this issue Mar 30, 2021
@vicperdana @BernieWhite
Added ability to detect optionality for each Parameter (#68)
a85b88d 
Added ability to detect "Required" or "Optional for each parameter. Closes #55

- Detects if parameter is either "Optional" or "Required" based on the availability of DefaultValue or AllowedValues
- Added a "Required" column
- Added "Required" and "Optional" badge for each parameter

Co-authored-by: Bernie White <bewhite@microsoft.com>
@vicperdana vicperdana mentioned this issue Mar 30, 2021
Merged
4 tasks
@BernieWhite BernieWhite mentioned this issue May 12, 2021
Merged
4 tasks
@jtracey93 jtracey93 mentioned this issue Sep 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vicperdana vicperdana

Labels
feature: documents Issues that affect Document definitions
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Added ability to detect optionality for each Parameter
2 participants
@vicperdana @BernieWhite