Only perform machineconfig reconciliation during OpenShift upgrades #3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkowl
force-pushed
the
hawkowl/machineconfig-on-upgrade
branch
from
40629c1
to
e7a374f
Compare
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Please rebase pull request. |
|
/azp run ci, e2e |
|
Pull request contains merge conflicts. |
hawkowl
force-pushed
the
hawkowl/machineconfig-on-upgrade
branch
from
070d418
to
a1c5985
Compare
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
hawkowl
added
ready-for-review
skippy
hawkowl
requested review from
jewzaam,
bennerv,
rogbas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012 and
jaitaiwan
as code owners
|
@SudoBrendan From what we discussed that we know that MIMO M0 and the UDR incident etchosts don't work with each other yet. There is a follow up task ARO-9990 to get these two to work together. Given that this work has been QEed several times already we should be good to push this PR in and use the follow up card to sort out any issues between this and the etchosts controller. |
SudoBrendan
approved these changes
Sep 9, 2024
| wantConditions: defaultConditions, | ||
| }, | ||
| { | ||
| name: "MachineConfigPool reconciliation does not existing DNS MachineConfigs when not updating", |
There was a problem hiding this comment.
nit: grammar, probably "does not update existing"?
… if cluster is upgrading
hawkowl
force-pushed
the
hawkowl/machineconfig-on-upgrade
branch
from
6ce74fc
to
761c4fb
Compare
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jaitaiwan
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-6250
What this PR does / why we need it:
Only performs MachineConfig reconciliation when OpenShift is being upgraded.
Test plan for issue:
Unit tests + E2E should cover it.
Is there any documentation that needs to be updated for this PR?
Yes, SOPs for manually forcing reconciliation
How do you know this will function as expected in production?
E2E + testing should cover known cases, but might require further testing.