Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PopoverMenuItem: more accurate itemComponent type #75914

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

monsieur-z
Copy link
Contributor

@monsieur-z monsieur-z commented Apr 18, 2023

Proposed Changes

This PR fixes the following error triggered by PopoverMenuItem. It is caused by an inaccurate PropType.

Screenshot 2023-04-18 at 12 17 03 PM

Here's an explanation of the fix.

Testing Instructions

  • Spin up Calypso, using a live link below, or by running the branch locally
  • Open the developer console
  • Visit /posts/:site
  • Click the 3 dotted menu of a post item

Screenshot 2023-04-18 at 12 17 08 PM

  • Check there's no error in the console

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@monsieur-z monsieur-z added the [Size] XS Tiny sized issue label Apr 18, 2023
@monsieur-z monsieur-z requested a review from a team April 18, 2023 16:21
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 18, 2023
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@monsieur-z monsieur-z merged commit e6ded91 into trunk Apr 19, 2023
@monsieur-z monsieur-z deleted the fix/pop-over-menu-item-type branch April 19, 2023 12:37
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Size] XS Tiny sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants