Add CI check for newspack-blocks textdomain

[noahtallen]

cc @akirk (for textdomain)
cc @scinos (for yarn install time)
cc @Automattic/ajax (for changes to the newspack sync step)

Follows conversation from #44125 (comment).

closes #44296

Changes proposed in this Pull Request

1. Move newspack-block synchronization to the build step rather than install step. This shaves 10 seconds off yarn install. IMO, this is preferred behavior since most wp-calypso devs do not care about it. Additionally, this should not change existing workflows, since you will have to run the build script before testing anyways.
2. Introduce workflow for newspack-blocks. This fails if:
   a) the newspack-blocks synced files do not exist
   b) the php textdomain of any synced files is not full-site-editing
3. Fail the build script if the build fails. This was a bug where the build script always exited with 0.
4. Fail the newspack sync script if phpcbf fails, triggering a build failure (reported in CI.)
5. Add a helpful message if the newspack sync script caused a build failure. This informs people that they might need to run composer install.

The convenient thing about the workflow is that it tests the generated artifact -- i.e. exactly the files which will be installed in WordPress.

Testing instructions

Locally, you can test both yarn and yarn build for the FSE plugin. However, most of this needed to be verified in CI. (see my screenshots in the comment below for proof)

• CI should pass.
• Test that CI fails if sync step does not happen
• Test that CI fails if there is an issue with phpcbf
• Test that CI fails if textdomain is not full-site-editing

[matticbot]

Test live: https://calypso.live/?branch=try/better-phpcbf-in-newspack-blocks

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[akirk]

Great idea and approach, thank you! Didn't take that much of a closer look yet but will do tomorrow.

[matticbot]

Caution: This PR affects files in the FSE Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D46698-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2

[noahtallen]

1. It fails when there are bad PHP textdomains in the synced newspack blocks:

2. It fails when the newspack blocks have not been synced:

3. Build fails when phpcbf fails:

4. It displays a helpful error message when the newspack build fails:

[deBhal]

I can't comment on the yarn/lerna lifecycle changes, and I made a couple of small suggestions and re-started the e2e builds to clear out an unrelated timeout, but it looks great overall 👍

[akirk]

Thank you, @deBhal for the assessemnt. I don't really have anything to add other than this is really helpful to avoid this in future. Thank you!

[noahtallen]

I've addressed the comments. it might be nice to get a ✅ , but I may merge anyways by the end of the day since this shouldn't affect much.

[scinos]

Thanks for improving yarn install times for everybody :)