WPCOM Block Editor: show dismiss button in IE 11 #44196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Bug
[Feature] Post/Page Editor
ramonjd
added
the
[Status] Needs Review
|
Caution: This PR affects files in the FSE Plugin on WordPress.com D46468-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2 |
andrewserong
approved these changes
Jul 16, 2020
|
Fantastic! Thank you |
…nterface-interface-skeleton__header otherwise the edit post header will appear on top.
p-jackson
force-pushed
the
fix/wpcom-block-editor-sidebar-button-ie11
branch
from
abc274b
to
963ea63
Compare
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
matticbot
removed
the
[Status] Needs Review
sarayourfriend
added a commit
that referenced
this pull request
Jul 16, 2020
This reverts commit 3caab24.
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
In IE 11, the WP logo we use to dismiss the sidebar seemed to... disappear...
To fix this, the click guards needs a z-index higher or equal to the
.interface-interface-skeleton__headerotherwise the edit post header will appear on top.Before
After
Testing instructions
Enable the sidebar by defining
WPCOM_BLOCK_EDITOR_SIDEBARastruein your sandbox.Apply D46468-code to sandbox
Find your favourite IE11 testing method (Browserstack?)
The WP logo button should be there.
Ensure it still works in other browsers :)
Fixes #44067