Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e2e tests for Gutenberg 8.0.0 #41505

Merged
merged 5 commits into from
Apr 29, 2020
Merged

Update e2e tests for Gutenberg 8.0.0 #41505

merged 5 commits into from
Apr 29, 2020

Conversation

andrewserong
Copy link
Member

@andrewserong andrewserong commented Apr 28, 2020 •
edited
Loading

Changes proposed in this Pull Request

  • This PR exists to run the e2e tests against Gutenberg 8.0.0-RC1 on Edge sites
  • Update e2e tests for compatibility where needed
  • Keep e2e tests backwards compatible for Gutenberg v7.8.1 so that we can merge in fixes prior to deploying Gutenberg 8.0.0
  • Make isBlockCategoryPresent check case insensitive due to v8.0.0 using uppercase for block categories, but v7.8.1 uses sentence case (it's either that or title case).

Testing instructions

  • Ensure all e2e tests and GB Edge e2e tests pass

Related to issue: #41504

@andrewserong andrewserong self-assigned this Apr 28, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/test-gutenberg-v8.0.0-rc1

@andrewserong andrewserong added the [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot label Apr 28, 2020
@andrewserong andrewserong mentioned this pull request Apr 28, 2020
Closed
17 tasks
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@andrewserong andrewserong changed the title Trigger E2E tests Update e2e tests for Gutenberg 8.0.0 Apr 28, 2020
@andrewserong andrewserong requested a review from a team as a code owner April 28, 2020 04:01
@andrewserong andrewserong requested review from a team and alshakero April 28, 2020 07:52
alshakero
alshakero approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code and checked the CI results. LGTM! Couldn't run tests locally due to #41541.

@andrewserong andrewserong force-pushed the update/test-gutenberg-v8.0.0-rc1 branch from 0b5773e to af80d69 Compare April 29, 2020 00:24
@andrewserong andrewserong merged commit 8092b0b into master Apr 29, 2020
@andrewserong andrewserong deleted the update/test-gutenberg-v8.0.0-rc1 branch April 29, 2020 01:42
@sirreal sirreal mentioned this pull request May 14, 2020
Closed
16 tasks
@yansern yansern mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alshakero alshakero alshakero approved these changes

Assignees

@andrewserong andrewserong

Labels
[Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewserong @matticbot @alshakero