Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line alignment for bootstrap themes #222

Merged
merged 3 commits into from
Nov 19, 2021
Merged

Conversation

merkushin
Copy link
Member

@merkushin merkushin commented Nov 16, 2021

Remove styling for the code container that Bootstrap accidentally adds.

Bootstrap has its own containers but it applies styles for all containers.

Fixes #192

Changes proposed in this Pull Request

  • Remove styling for the code container that was added by Bootstrap

Testing instructions

  • Add a SyntaxHighlighter to the post with at least one line of code.
  • Open the post on the frontend.

Screenshot / Video

Before:
CleanShot 2021-11-16 at 11 48 06@2x

After:
CleanShot 2021-11-16 at 11 44 55@2x

@merkushin merkushin added this to the 3.6.1 milestone Nov 16, 2021
@merkushin merkushin self-assigned this Nov 16, 2021
Copy link
Contributor

@renatho renatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well! Just a small suggestion to add a comment saying that it's just to fix a conflict with themes. So we know that it doesn't have any purpose related to our styles. ;)

@@ -7,7 +7,7 @@
*
* @version
* 3.0.83 (July 02 2010)
*
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for documentation purposes:

I thought it was a vendor file, but it seems there are some other changes that were applied to this file already, like this one: 9fc4a58

So probably it's not a big deal to change this file. Also, since that lib is not being maintained anymore, probably we won't have new versions to update this file. :)

syntaxhighlighter3/styles/shCore.css Show resolved Hide resolved
Remove styling for the code container that Bootstrap accidentally adds.
Copy link
Contributor

@renatho renatho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@merkushin merkushin merged commit accca1c into master Nov 19, 2021
@merkushin merkushin deleted the fix/line-alignment branch November 19, 2021 16:54
@merkushin merkushin mentioned this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spacing issue on themes with Bootstrap CSS
2 participants