Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add syntax highlight for Haskell #210

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Add syntax highlight for Haskell #210

merged 1 commit into from
Sep 7, 2021

Conversation

bor0
Copy link
Member

@bor0 bor0 commented Apr 9, 2021

Inspired by #53

Changes proposed in this Pull Request

  • Add support for Haskell

Testing instructions

  1. Add syntaxhighlighter block
  2. Select Haskell as a language
  3. Copy paste some code from https://github.com/bor0/misc/blob/master/2021/Haskelogic/Gentzen.hs
  4. Save and preview
  5. Make sure its syntax highlighted

Screenshot / Video

wp-admin:
Screenshot 2021-04-09 at 12 50 58

Frontend:
Screenshot 2021-04-09 at 12 51 02

@bor0 bor0 requested review from jom, yscik, renatho and gikaragia April 9, 2021 10:51
@bor0 bor0 self-assigned this Apr 9, 2021
@bor0
Copy link
Member Author

bor0 commented May 12, 2021

@yscik thanks for updating the status on this one. Should I just merge it at this point?

@yscik
Copy link
Contributor

yscik commented May 14, 2021

👋 It'll still need to be reviewed, but the flags should put it in our queue.

yscik
yscik approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@yscik yscik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yscik yscik added this to the 3.6.1 milestone Jun 7, 2021
@gikaragia gikaragia merged commit 788ecca into master Sep 7, 2021
@merkushin merkushin mentioned this pull request Nov 29, 2021
Merged
@sirreal sirreal deleted the add/haskell branch October 26, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yscik yscik yscik approved these changes

@jom jom Awaiting requested review from jom

@renatho renatho Awaiting requested review from renatho

@gikaragia gikaragia Awaiting requested review from gikaragia

Assignees

@bor0 bor0

Labels
[Pri] Normal [Status] Accepted [Type] Enhancement
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bor0 @yscik @gikaragia