Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http strings to https where possible #77

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

hassanelnajjar
Copy link

@hassanelnajjar hassanelnajjar commented Jun 12, 2021

search for http: and check the url using chrome and then change the secure url to https

relates #73

Changes

This pull request makes the following changes:

search for http: and check the url using chrome and then change the secure url to https

Why

For #

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

Additional information

INN Member/Labs Client requesting: (if applicable)

  • Contributor has read INN's GitHub code of conduct
  • Contributor would like to be mentioned in the release notes as: (fill in this blank)
  • Contributor agrees to the license terms of this repository.

@benlk
Copy link
Collaborator

benlk commented Jun 14, 2021

I'm no longer a maintainer on this project, so the folks at Automattic can overrule me on this, but:

In js/pym.js, you do change one http to https, but you also changed the whitespace and formatting of the entire file. That's not optimal, especially since js/pym.js is a file that was copied in directly from a third party. Can you revert the whitespace changes, please?

@hassanelnajjar
Copy link
Author

I'm no longer a maintainer on this project, so the folks at Automattic can overrule me on this, but:

In js/pym.js, you do change one http to https, but you also changed the whitespace and formatting of the entire file. That's not optimal, especially since js/pym.js is a file that was copied in directly from a third party. Can you revert the whitespace changes, please?

I fixed the white spaces :)

@benlk
Copy link
Collaborator

benlk commented Jun 14, 2021

This patch looks much cleaner now; thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants