Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.x migration guide: fix setter change example code #7546

Merged
merged 2 commits into from
Feb 21, 2019

Conversation

freewil
Copy link
Contributor

@freewil freewil commented Feb 20, 2019

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory.

If you're making a change to documentation, do not modify a .html file directly. Instead find the corresponding .jade file or test case in the test/docs directory.

Summary

minor fixes related to 5.x migration guide, specifically setter order change. Please confirm that getters are not affected in migration to 5.x.

@freewil freewil changed the title migration guide: fix setter change example code 5.x migration guide: fix setter change example code Feb 20, 2019
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vkarpov15 vkarpov15 added this to the 5.4.15 milestone Feb 21, 2019
@vkarpov15 vkarpov15 added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label Feb 21, 2019
@vkarpov15 vkarpov15 merged commit b6327e9 into Automattic:master Feb 21, 2019
@freewil freewil deleted the migration-5-setters branch February 21, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants