feat: add transactionAsyncLocalStorage option to opt in to automatically setting session on all transactions #14742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
requested changes
Jul 11, 2024
There was a problem hiding this comment.
Code looks good to me, though i would recommend to add a note to the documentation that it makes use of a experimental nodejs API below 16.4.0 (as added in the types by me and listed under AsyncLocalStorage's History).
also i just noticed that option transactionAsyncLocalStorage (in latest docs) only returns a result for docs/transactions.html, maybe it should be mentioned as a possible option for mongoose.set.
aside from that, there are some minor doc suggestions that should be done.
Co-authored-by: hasezoey <hasezoey@gmail.com>
Co-authored-by: hasezoey <hasezoey@gmail.com>
…session option with transactionAsyncLocalStorage; backport #14744
hasezoey
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #14583 to 7.x
Re: #13889
Summary
Add
transactionAsyncLocalStorageoption to 7.x. Should work fine because Node v14.x has "experimental" support for the same AsyncLocalStorage API that became stable in 16.x.Examples