Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg Block for Tweet Shortcode? #7597

Closed
wants to merge 21 commits into from
Closed

Gutenberg Block for Tweet Shortcode? #7597

wants to merge 21 commits into from

Commits on Aug 4, 2017

  1. A good start maybe?

    @georgestephanis
    georgestephanis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    728f07a View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2017

  1. Correct how we refer to the tweet attribute.

    @georgestephanis
    georgestephanis committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    f3c43aa View commit details
    Browse the repository at this point in the history

  2. Update the prop when the field changes. Still not thrilled with this … 

    …method.
    @georgestephanis
    georgestephanis committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    b9da75c View commit details
    Browse the repository at this point in the history

  3. Add a dummy function to explore how we can parse this on initialization.

    @georgestephanis
    georgestephanis committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    1fbb0d4 View commit details
    Browse the repository at this point in the history

  4. Somewhat tidier way of doing the script. 

    This lets it be inline on the page, with the other scripts -- rather
than printed at the very bottom.

Leaving the `script` tags there but commented out so PHPStorm still
syntax highlights it as js.
    @georgestephanis
    georgestephanis committed Aug 5, 2017
    Configuration menu
    Copy the full SHA
    6817940 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2017

  1. Clear out some unused chaff.

    @georgestephanis
    georgestephanis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    2e98277 View commit details
    Browse the repository at this point in the history

  2. Flesh out how to find the tweet url from the node.

    @georgestephanis
    georgestephanis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    7b3729b View commit details
    Browse the repository at this point in the history

  3. Don't return the result of the array directly. 

    Build, then compile.  This will make it easier for us to add more
conditional additions later.
    @georgestephanis
    georgestephanis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    eb7499e View commit details
    Browse the repository at this point in the history

  4. Use onChange not onInput to satisfy browser console nag.

    @georgestephanis
    georgestephanis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    3d3cb22 View commit details
    Browse the repository at this point in the history

  5. Add in handling for other optional attributes.

    @georgestephanis
    georgestephanis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    9b2f478 View commit details
    Browse the repository at this point in the history

  6. Wrap it in the generated classname? Probably a good idea?

    @georgestephanis
    georgestephanis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    9b22ae0 View commit details
    Browse the repository at this point in the history

  7. Oops, forgot the closing parens.

    @georgestephanis
    georgestephanis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    6fbc6c2 View commit details
    Browse the repository at this point in the history

  8. Set the generated shortcode to single.

    @georgestephanis
    georgestephanis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    fb52f65 View commit details
    Browse the repository at this point in the history

  9. Change to an array so we can return multiples.

    @georgestephanis
    georgestephanis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    2b8a30a View commit details
    Browse the repository at this point in the history

  10. Add BlockControls AlignmentToolbar.

    @georgestephanis
    georgestephanis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    8d9f1f4 View commit details
    Browse the repository at this point in the history

  11. Add sidebar width control.

    @georgestephanis
    georgestephanis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    0b5476f View commit details
    Browse the repository at this point in the history

  12. If there's a className to be set, wrap it in a div so it can be set o… 

    …n that.
    @georgestephanis
    georgestephanis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    baa38bc View commit details
    Browse the repository at this point in the history

  13. This is necessary so React doesn't turn " into "

    @georgestephanis
    georgestephanis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    ba90d71 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2017

  1. Rewrite attributes array to a function.

    George Stephanis authored and George Stephanis committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    32a0ea5 View commit details
    Browse the repository at this point in the history

  2. Are you the keymaster? 

    https://www.youtube.com/watch?v=pNnIbFFzpD8
    George Stephanis authored and George Stephanis committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    1f52720 View commit details
    Browse the repository at this point in the history

  3. Alias el to wp.element.createElement 

    For brevity.
    George Stephanis authored and George Stephanis committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    ebe3953 View commit details
    Browse the repository at this point in the history