Skip to content

Commit

Permalink
Cleanup pnpm overrides
Browse files Browse the repository at this point in the history
* Pnpm has started wanting to update `@storybook/builder-webpack5`
  with every upstream release. Giving the relevant overrides a version
  makes it stick with the lockfile.
* `@automattic/format-currency` seems a bit outdated. We can clean up a
  lot of the old deps we have in pnpm-lock.yaml by updating its dep on
  `i18n-calypso` from 4.x to 5.x, and in turn updating `i18n-calypso`'s
  dep on `interpolate-components` 1.1.0 too.
* `jest-environment-enzyme` is [supposedly not dead][1], but still isn't
  being updated for several months. For our purposes at least it seems
  to work fine with jest-environment-jsdom 27.
* Looks like we've dropped the dep on whatever old version of
  `terser-webpack-plugin` had a dep on an old version of
  `serialize-javascript`, so drop the override.

[1]: enzymejs/enzyme-matchers#353
  • Loading branch information
anomiex committed Dec 3, 2021
1 parent 49eac34 commit 841ea55
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 185 deletions.
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,16 @@
},
"pnpm": {
"overrides": {
"@storybook/addon-docs>@storybook/builder-webpack4": "npm:@storybook/builder-webpack5",
"@automattic/format-currency>i18n-calypso": "^5",
"@storybook/addon-docs>@storybook/builder-webpack4": "npm:@storybook/builder-webpack5@^6",
"@storybook/core-common>webpack@4": ">= 4",
"@storybook/core-server>webpack@4": ">= 4",
"@storybook/core-server>@storybook/builder-webpack4": "npm:@storybook/builder-webpack5",
"@storybook/core-server>@storybook/manager-webpack4": "npm:@storybook/manager-webpack5",
"@storybook/core-server>@storybook/builder-webpack4": "npm:@storybook/builder-webpack5@^6",
"@storybook/core-server>@storybook/manager-webpack4": "npm:@storybook/manager-webpack5@^6",
"@storybook/react>webpack@4": ">= 4",
"isomorphic-fetch>node-fetch@^1.0.1": "^2.6.1",
"jest-environment-jsdom@^24.0.0": "^26.0.1",
"i18n-calypso>interpolate-components": "npm:@automattic/interpolate-components@^1.2.0",
"jest-environment-enzyme>jest-environment-jsdom@^24.0.0": "^27",
"react-dev-utils>browserslist@^4": "^4",
"terser-webpack-plugin>serialize-javascript@^4.0.0": "^5.0.0",
"trim@0.0.1": "^0.0.3",
"yargs>yargs-parser@^5.0.1": "^20.0.0"
}
Expand Down
Loading

0 comments on commit 841ea55

Please sign in to comment.