Add workaround to preserve CSS calc() functions #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
commented
May 4, 2018
| $open_parens++; | ||
| } elseif ( ')' === $css[ $final_offset ] ) { | ||
| $open_parens--; | ||
| } |
There was a problem hiding this comment.
Probably should add a case here to catch ; or } and break because clearly that indicates unbalanced parentheses and we should skip to looking for the next match from that point forward.
There was a problem hiding this comment.
👍 It looks like the elseif block below now handles that case.
kienstra
approved these changes
May 4, 2018
There was a problem hiding this comment.
Approved
Hi @westonruter,
Thanks, this pull request looks good, and it allowed outputting calc values to <style amp-custom>, like:
calc(100% + 2rem)
calc(70vmax - 300px)
calc(0px - 3.5rem)Good idea to store them in placeholders, and replace them later.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that CSS
calc()functions aren't parsed properly by the CSS parser. There is an old issue open to support them: MyIntervals/PHP-CSS-Parser#79. In the mean time, this makes sure that these functions are preserved by replacing them with placeholders prior to parsing, and then returning the original functions after parsing.