Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSS Parser to eliminate CSS3 calc() workaround #1240

Closed
1 task
westonruter opened this issue Jul 2, 2018 · 1 comment
Closed
1 task

Update CSS Parser to eliminate CSS3 calc() workaround #1240

westonruter opened this issue Jul 2, 2018 · 1 comment
Labels
Milestone

Comments

@westonruter
Copy link
Member

westonruter commented Jul 2, 2018

As a site admin, I should have the fix that eliminates CSS3 calc() workarounds inside the AMP core codebase.

  • AC1: Merge in the code (as specified below) and validate the CSS parser works as expected, removing the lingering workaround in our plugin core.

In #1116 we added a workaround to preserve CSS3 calc() functions since they weren't supported in PHP-CSS-Parser. However, now they are: MyIntervals/PHP-CSS-Parser#128. So we can merge the latest into our fork and eliminate the calc() placeholders.

@westonruter westonruter added this to the v1.0 milestone Jul 2, 2018
@postphotos
Copy link
Contributor

Hi @westonruter, Thanks for this! I've written up a quick user story here. It sounds like this should be pretty straightforward to squeeze into our v1.0 stable release. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants