Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: add build against PHP 8.0 #599

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Dec 4, 2020

PHP 8.0 has been branched off two months ago, so nightly is now PHP 8.1 and in the mean time PHP 8.0 was released last week.

As of today, there is a PHP 8.0 image available on Travis.

This PR adds a two new builds against PHP 8.0 to the matrix and, as PHP 8.0 has been released, these builds are not allowed to fail.

PHPCS 3.5.7 is the first PHPCS version which is runtime compatible with PHP 8.0.
Once the minimum supported PHPCS version of this package has been upped to PHPCS 3.5.7, these builds don't need to be special cased anymore.

PHP 8.0 has been branched off two months ago, so `nightly` is now PHP 8.1 and in the mean time PHP 8.0 was released last week.

As of today, there is a PHP 8.0 image available on Travis.

This PR adds a two new builds against PHP 8.0 to the matrix and, as PHP 8.0 has been released, these builds are not allowed to fail.

PHPCS 3.5.7 is the first PHPCS version which is runtime compatible with PHP 8.0.
Once the minimum supported PHPCS version of this package has been upped to PHPCS 3.5.7, these builds don't need to be special cased anymore.
@jrfnl jrfnl added this to the 2.3.0 milestone Dec 4, 2020
@jrfnl jrfnl requested a review from a team as a code owner December 4, 2020 06:33
@GaryJones GaryJones merged commit 60ad148 into develop Dec 4, 2020
@GaryJones GaryJones deleted the feature/travis-test-against-php8-no-failure branch December 4, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants