Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test bootstrap: various minor tweaks #558

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Jul 27, 2020

  • Remove some code duplication by using an interim variable.
  • Check that the PHPCS native bootstrap file can be found.
  • Remove the question about using PHPCS 3.x. That's not in question anymore.
  • Fix the link to the contributing.md file - this was previously pointing to the WPCS one.
  • Set the PHPCS_IGNORE_TESTS environment variable automatically to the correct value to prevent running tests from other standards.

* Remove some code duplication by using an interim variable.
* Check that the PHPCS native bootstrap file can be found.
* Remove the question about using PHPCS 3.x. That's not in question anymore.
* Fix the link to the contributing.md file - this was now pointing to the WPCS one.
* Set the `PHPCS_IGNORE_TESTS` environment variable automatically to the correct value to prevent running tests from other standards.
@jrfnl jrfnl added this to the 2.2.0 milestone Jul 27, 2020
@jrfnl jrfnl requested a review from a team as a code owner July 27, 2020 20:52
@GaryJones GaryJones merged commit f5bde12 into develop Jul 27, 2020
@GaryJones GaryJones deleted the fix/test-bootstrap-various-tweaks branch July 27, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants