-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MHCADDI model #74
MHCADDI model #74
Conversation
@sebastiandro I will look into the segmentation indices. |
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 95.11% 95.75% +0.63%
==========================================
Files 30 32 +2
Lines 1188 1366 +178
==========================================
+ Hits 1130 1308 +178
Misses 58 58
Continue to review full report at Codecov.
|
Will not merge without a complete rewrite of the variable names and docstrings. |
After that's all done I'll take a other pass at review |
@cthoyt Simplified it massively. |
- use new-style `super().__init__()` - improve some (but not all) type annotations - Add FIXME
@cthoyt can I merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the TODOs in the code highlighted in the PR
Closes #13
Summary
Please provide a high-level summary of the changes for the changes and notes for the reviewers
Changes
! This is a draft, the model still need a bit of refactoring, documentation etc