Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable ws server keep alive #24

Merged
merged 2 commits into from
Apr 13, 2018
Merged

enable ws server keep alive #24

merged 2 commits into from
Apr 13, 2018

Conversation

psadaic
Copy link
Contributor

@psadaic psadaic commented Apr 13, 2018

Enabled native Ratchet keep alive support for WebSocket server instance.

@gcphost
Copy link
Contributor

gcphost commented Apr 13, 2018 •
edited
Loading

Thanks!

Can you make the timer setting of 30 be configurable? Optional as well in the event one does not want the keepalive.

 $this->wsServerInstance->enableKeepAlive($this->getEventLoop(), 30);

@psadaic
Copy link
Contributor Author

psadaic commented Apr 13, 2018

Here you go.

gcphost
gcphost approved these changes Apr 13, 2018
View reviewed changes
Copy link
Contributor

@gcphost gcphost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for updating with the config option.

@gcphost gcphost merged commit 1a9a5d3 into Askedio:master Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcphost gcphost gcphost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psadaic @gcphost