Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make styling consistent #45

Merged
merged 1 commit into from
Jul 10, 2016
Merged

Make styling consistent #45

merged 1 commit into from
Jul 10, 2016

Conversation

armababy
Copy link
Member

@armababy armababy commented Jul 8, 2016

Make styling of single and multiple partials consistent.
In single partial we have double figure styling when media is selected also when no media selected empty figure element borders visible.

Before empty (border dot under upload button)
cosmetic_before_empty

Before (double figure styling)
cosmetic_before

After (single figure styling wrap with div)
cosmetic_after

After empty
cosmetic_after_empty

@armababy
Copy link
Member Author

armababy commented Jul 8, 2016

Meh sec, will remove that cursor grab on single and will squash.

Edit: Done

Removed grab cursor for single partial

Disable sortable on single partial view

Fix edit view if media is present

Use data-id

for the sake of consistency with javascript code example.
@nWidart
Copy link
Member

nWidart commented Jul 10, 2016

Thank you! 😄

@nWidart nWidart merged commit e8c3bee into AsgardCms:master Jul 10, 2016
@nWidart
Copy link
Member

nWidart commented Jul 10, 2016

I uploaded a picture and it still has the double border thing going on.

screen shot 2016-07-10 at 10 30 40

@armababy
Copy link
Member Author

i only did this for new-file-link-single, probably should do also for file-link-single.

@nWidart
Copy link
Member

nWidart commented Jul 10, 2016

Ah I see. I indeed tested it on the edit single partial.

@armababy
Copy link
Member Author

Will PR in couple mins, need to resync repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants