Allow bundleID instead of AppID #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because it already recently performed a check. Also fixed a minor typo (verson instead of version)
Also bundleID (next to, or instead of appID) can now be used to get the info from the App Store. If the bundleID is given and an appID is not supplied, the appID will be read from the App Store json, since it is later needed when attempting to open the App Store link after "Upgrade"
|
One more thing to mention: I chose for the bundleID to be a variable which needs to be set before a version check is performed. Alternatively, we could get the bundleID automatically from the |
|
Will take a look this weekend - thanks! |
|
I'm closing this PR and opening an other ( #54 ) , based from a feature branch, to separate this PR from another feature PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An app's bundleID can be used, just as the appID to get App Store information about it.
It is useful to also have this feature in Siren, because it will be easier for the developer to get the bundleIdentifier instead of the appID (especially when the app hasn't been approved and released yet).