[Bug fix] set "en_US_POSIX" as the locale of the date formatter #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch. Mind making the same fix here? https://github.com/ArtSabintsev/Harpy/blob/master/Harpy/Harpy.m#L461 Merging this in and will cut a new build in a moment. |
|
Now available in v2.0.6. Thanks! |
nixnoughtnothing
added a commit
to nixnoughtnothing/Harpy
that referenced
this pull request
Jun 19, 2017
ArtSabintsev
pushed a commit
to ArtSabintsev/Harpy
that referenced
this pull request
Jun 19, 2017
|
Thanks for the quick updates! 👍 👍 👍 |
|
Updated Harpy as well. Of course! Thanks for finding this bug! Enjoy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
It seems like Siren doesn’t work due to a dateFormatter issue in case a user turns off 24-Hour Time or sets to the Japanese Calendar on the iPhone.
https://github.com/ArtSabintsev/Siren/blob/master/Sources/SirenDateExtension.swift#L19-L24
Hope this PR will be merged soon. Thanks!