This repository has been archived by the owner on Nov 22, 2020. It is now read-only.
Fixed warnings that come up when opening AppStore link #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pressing the 'Update' button that opens up AppStore shows these warnings: ``` _BSMachError: (os/kern) invalid capability (20) _BSMachError: (os/kern) invalid name (15) ``` This simple fix makes sure alert action is handled on main thread which in return doesn't show any warnings. Relevant stackoverflow answer: http://stackoverflow.com/a/33639650/2734193
|
Interesting. I didn't realize it wasn't running on the UI thread. I'll do some poking around before accepting the PR. Will get back to you soon. Thanks! |
|
Looks good 👍 |
|
It's available in Harpy v4.0.4 (via CocoaPods and Carthage) It's also available on http://github.com/ArtSabintsev/Siren I gave you credit in both repos in their respective CONTRIBUTORS.md files. Thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing the 'Update' button that opens up AppStore shows these warnings:
This simple fix makes sure alert action is handled on main thread which in return doesn't show any warnings. Relevant stackoverflow answer: http://stackoverflow.com/a/33639650/2734193