Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove fibers so it can be built with node 16+ #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tcdw
Copy link

@tcdw tcdw commented Nov 14, 2021

Make sure the PR fulfills these requirements:

  • When resolving a specific issue, make sure it's referenced in the PR's title (e.g. Closes #xxx[,#xxx], where "xxx" is the issue number)

  • If adding a new feature, the PR's description includes: A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

  • If this PR introduce a breaking change, please describe the impact and migration path for existing applications

What kind of change does this PR introduce?

Remove node-fibers, so this project can be built with Node 16+.

More information:

According to node-fibers's readme, that project is obsolete, and will not work on Node 16+.

Since fibers is an optional dependency, it can be safely removed. The performance will be dropped, but at least you can keep using the latest LTS version of Node.js now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant