AP_Scripting: no warning if no ./scripts and no real filesystem

[peterbarker]

it is possible to build for boards without storage (so no Posix, no Fatafs), but still have scripts in ROMFS.

In this case we will use the backend AP_Filesystem_backend base class when doing file operations. This will alway fail to open directories, so when we try to load scripts from SCRIPTS_DIRECTORY it will always fail.

This leads to a warning being emitted:

Lua: State memory usage: 2796 + 5227
AP: Lua: open directory (./scripts) failed
AP: hello, world
Time has wrapped

Which isn't great.

Detect we are working on this filesystem and don't warn.

Alternative to https://github.com/ArduPilot/ardupilot/pull/27404/files

I've tested this on CubeOrange - warning is still emitted there (even if you're running scripts out of ROMFS already!)

STABILIZE> Got COMMAND_ACK: SCRIPTING: ACCEPTED
AP: Scripting: stopped
AP: Scripting: restarted
Lua: State memory usage: 2796 + 5431
AP: Lua: open directory (/APM/scripts) failed
AP: hello, world
AP: PreArm: RC not found

[peterbarker]

My testing was done on SDMODELH7v1 with this hwdef modification:

--- a/libraries/AP_HAL_ChibiOS/hwdef/SDMODELH7V1/hwdef.dat
+++ b/libraries/AP_HAL_ChibiOS/hwdef/SDMODELH7V1/hwdef.dat
@@ -2,3 +2,6 @@ include ../KakuteH7v2/hwdef.dat
 
 # board ID for firmware load
 APJ_BOARD_ID 1111
+
+undef AP_SCRIPTING_ENABLED
+define AP_SCRIPTING_ENABLED 1
pbarker@fx:~/rc/ardupilot(pr/no-warning-text-message-script-dir-open)$ 

[IamPete1]

The advantage of the define approach is that we can error out at compile time if someone has scripting turned on and no way to load a script.

[peterbarker]

The advantage of the define approach is that we can error out at compile time if someone has scripting turned on and no way to load a script.

That could/should be done as a separate check. I think it would be something like this:

#if AP_SCRIPTING_ENABLED
#if !AP_FILESYSTEM_POSIX_ENABLED && !AP_FILESYSTEM_FATFS_ENABLED && !AP_FILESYSTEM_ESP32_ENABLED && !AP_FILESYSTEM_ROMFS_ENABLED
#error "Scripting enabled but nowhere to read scripts from!"
#endif
#endif  // AP_SCRIPTING_ENABLED

I've no idea where that might live, however. Perhaps at the top of the file I'm modifying in here?

The reason I think these are separate things is that the user might be pointing SCRIPTING_DIRECTORY somewhere odd - like @ROMFS/extra_scripts, and that requires a runtime check.

[IamPete1]

I've no idea where that might live, however. Perhaps at the top of the file I'm modifying in here?

We a check in config.h already, I think it would have to be updated as you sugest.

ardupilot/libraries/AP_Scripting/AP_Scripting_config.h

Line 12 in 868a650

#error "Scripting requires a filesystem"

[peterbarker]

I've no idea where that might live, however. Perhaps at the top of the file I'm modifying in here?

We a check in config.h already, I think it would have to be updated as you sugest.

ardupilot/libraries/AP_Scripting/AP_Scripting_config.h

Line 12 in 868a650

#error "Scripting requires a filesystem"

#28027