Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copter: Change the definitions of the direct values 0 and 1 to the definition names DISABLED and ENABLED #27757

Conversation

muramura
Copy link
Contributor

@muramura muramura commented Aug 5, 2024

Copter defines DISABLED as 0 and ENABLED as 1. Using these defined names makes the settings clearer.

@peterbarker
Copy link
Contributor

We agreed at DevCall to go entirely the other direction, and we've merged PRs into Rover, Tracker, Blimp and Plane to do that.

Did you want to rework this to go the other way?

@peterbarker
Copy link
Contributor

We're going the other way with this. The raw ENABLED and DISABLED defines make using these words in the libraries problematic. It's why we sometimes use "NONE" in enumerations rather than "DISABLED"!

#28004

Thanks anyway!

@peterbarker peterbarker closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants