Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sepolia network under ethereum ecosystem [APE-694] #1331

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

challet
Copy link
Contributor

@challet challet commented Mar 6, 2023

What I did

  • add the sepolia network to ape_ethereum
  • add the sepolia network to ape_geth

How I did it

By adding references to it where it seemed suitable

How to verify it

ape console --network etherum:sepolia:[rpc-url]
ape console --network etherum:sepolia:geth 

Haven't tried the second one, see the geth PR about sepolia support

Checklist

  • All changes are completed
  • New test cases have been added (more specifically : test data to an existing case)
  • Documentation has been updated (the new network is shown in the ape networks list command output, if that fells under documentation)

@NotPeopling2day NotPeopling2day changed the title feat: add sepolia network under ethereum ecosystem feat: add sepolia network under ethereum ecosystem [APE-694] Mar 6, 2023
Copy link
Contributor Author

@challet challet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add it to the EthereumConfig class as well but that led to a validation error that I didn't get

pydantic.error_wrappers.ValidationError: 1 validation error for EthereumConfig
sepolia
field required (type=value_error.missing)

Edit : I think I understand it is for plugins to have the property implemented

@challet challet marked this pull request as ready for review March 6, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants