Lazy-load the TUI #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change: Localize all non-stdlib imports. - Change: Define `Loop` within `init()`.
- Change: Import `.tui` if and only of launching the TUI. - Change: Use `BaseImage` instances in image lists instead of `Image` widget instances.
- Change: Reconfigure the TUI when initializing it instead of immediately after loading user config.
- Change: `.tui.main.quitting` -> `.tui.quitting`. Eliminates the need to load sub-modules of `.tui` in order to access the quitting status.
- Change: Import from `.tui` in `load()`, if and only if not skipping the TUI loading indication phase. - Change: Do not import submodules of `.tui` at module level.
- Fix: Resolve circular imports caused by interdependencies between submodules of `.tui`.
- Fix: Change annotation of `.tui.main.loop` from `Loop` to `urwid.MainLoop`, since `Loop` is now defined within `.tui.init()`. - Change: Remove unnecessary import of `.tui`.
AnonymouX47
added
the
improvement
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load submodules of
.tui, if and only if the TUI is launched.Interestingly, I'm yet to perceive any significant (even if a little) performance implications.