Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .gitignore ignoring everything that wasn't yet tracked #27

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

Crystalwarrior
Copy link
Collaborator

Currently, any additions to the repo will not be seen, even if it's in supposedly tracked folders - this is because the .gitignore wildcards are ignored due to its current set up. For example:

# Ignores everything
/*
# Except:
# the main plugin
!/addons/dialog_plugin/*

Will fail, because dialog_plugin is an ignored folder.
The solution is:

# Ignores everything
/*
# Except:
# the main plugin
!/addons/dialog_plugin/
!/addons/dialog_plugin/*

making the folder and the wild card both work. From what I understand, order matters. The folder has to be excepted FIRST, and the wild card added SECOND.
At the very least, the order matters if you want to make exceptions to exceptions - like I did by making it so .import files are not included regardless.

This occurred due to the wildcard * only working on folders that are still valid before (aka we have to exclude the folder itself before wild-carding inside of it).
@Crystalwarrior
Copy link
Collaborator Author

Re-created from #27 to fix commit history shenanigans, I made a branch of a branch by accident there.

Copy link
Owner

@AnidemDex AnidemDex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a great idea, but it need some changes before being merged.

.gitignore Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
…in and WAT unit testing plugin

Stop ignoring .import files, as they are important for letting Godot know the import settings of the files
@AnidemDex AnidemDex merged commit 4a79c2f into AnidemDex:main Aug 17, 2021
@Crystalwarrior Crystalwarrior deleted the fix-gitignoree branch December 30, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants