Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use git2 default features as they are not needed. #4

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

Byron
Copy link
Contributor

@Byron Byron commented Jul 1, 2023

This reduces the amount of dependencies from 102 to 94.


❯ cargo tree  | wc -l
     102

GQL ( master) +54 -2 [!]
❯ gco -b no-featu

GQL ( master) +54 -2 [!]
❯ hx Cargo.toml

GQL ( master) +55 -3 [!] took 23s
❯ cargo tree  | wc -l
      94

This reduces the amount of dependencies from 102 to 94.
@Byron
Copy link
Contributor Author

Byron commented Jul 1, 2023

Please note that I also thought I'd look into what it would mean to switch from git2 to gix, but felt I wouldn't be of much help here since it appears there is not a single test to validate the new gix backend against.

If that changes and you are interested in the additional performance you'd undoubtedly get I'd be happy to do an oxidization analysis to see if gix provides all the features you'd need. From what I saw, the answer would be a positive one and a transition is already possible.

@AmrDeveloper
Copy link
Owner

Hello @Byron,

Thank you for reducing dependencies.

For now all i used from Git2 is the read feature and I Think yes gix will be a good option and will cover the project need, Until test functions are created to cover the backend i will try gix in side project or maybe in other branch to get familiar with it and check the other features.

Thank you,
Amr Hesham

@AmrDeveloper AmrDeveloper merged commit 10c55f8 into AmrDeveloper:master Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants