Aip 6 rule #272
Merged
Aip 6 rule #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivshti
approved these changes
May 6, 2020
|
@samparsky well done, I found no issues! Soon I'll make issues for adapting this for the new targeting rules system, which will just mean we'll have to rename most of the code in this PR. The matching of rules itself (AIP6) will have to be rewritten. |
Ivshti
reviewed
May 6, 2020
| @@ -64,6 +72,14 @@ function makeRecorder(channelId) { | |||
| return hasAccess | |||
| } | |||
|
|
|||
| const priceRuleModifyEvs = events.filter(x => x.type === eventTypes.update_price_rules) | |||
There was a problem hiding this comment.
you can use find here rather than relying on filter and then getting the last element
There was a problem hiding this comment.
Find will return the first item in the list it finds and not the last item
| const priceRuleModifyEvs = events.filter(x => x.type === eventTypes.update_price_rules) | ||
| if (priceRuleModifyEvs.length) { | ||
| // if there are multiple evs only apply the latest | ||
| await updateChannelPriceMultiplicationRules(priceRuleModifyEvs[priceRuleModifyEvs.length - 1]) |
There was a problem hiding this comment.
I think it's much better to not use a lambda function here but to call await channelsCol.updateOne( directly..it would be much more readable
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #268