add: update impression price and pause channel event #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samparsky
force-pushed
the
157-change-impression-price
branch
from
c677d2f
to
99cf2e8
Compare
Ivshti
changed the title
Ivshti
requested changes
Jun 3, 2019
samparsky
force-pushed
the
157-change-impression-price
branch
3 times, most recently
from
78f7fb4
to
35156a6
Compare
Ivshti
requested changes
Jun 6, 2019
There was a problem hiding this comment.
we should also update channelPromise on throttledPersistAndReset, cause otherwise if we're running in cluster, we will never get the price updated
also it's a good idea to start applying the new price with the next aggregate, which will ensure more (not fully) deterministic behavior
that means that you should ONLY update the channelpromise there
samparsky
force-pushed
the
157-change-impression-price
branch
from
35156a6
to
1afd1fb
Compare
samparsky
changed the title
samparsky
force-pushed
the
157-change-impression-price
branch
2 times, most recently
from
34064b0
to
34d8264
Compare
samparsky
force-pushed
the
157-change-impression-price
branch
from
34d8264
to
670d705
Compare
Ivshti
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157 and #159